Re: [PATCH v4 2/2] drivers/perf: hisi: Add driver for HiSilicon PCIe PMU

[liuqi (BA)]

On 2021/5/19 19:40, John Garry wrote:
> On 19/05/2021 10:49, Qi Liu wrote:
> > PCIe PMU Root Complex Integrated End Point(RCiEP) device is supported
> > to sample bandwidth, latency, buffer occupation etc.
> >
> > Each PMU RCiEP device monitors multiple Root Ports, and each RCiEP is
> > registered as a PMU in /sys/bus/event_source/devices, so users can
> > select target PMU, and use filter to do further sets.
> >
> > Filtering options contains:
> > event        - select the event.
> > subevent     - select the subevent.
> > port         - select target Root Ports. Information of Root Ports
> >                 are shown under sysfs.
> > bdf          - select requester_id of target EP device.
> > trig_len     - set trigger condition for starting event statistics.
> > trigger_mode - set trigger mode. 0 means starting to statistic when
> >                 bigger than trigger condition, and 1 means smaller.
> > thr_len      - set threshold for statistics.
> > thr_mode     - set threshold mode. 0 means count when bigger than
> >                 threshold, and 1 means smaller.
> >
> > Reviewed-by: John Garry <john.garry@xxxxxxxxxx>
> > Signed-off-by: Qi Liu <liuqi115@xxxxxxxxxx>
>
> JFYI, In light of this following series:
> https://lore.kernel.org/linux-arm-kernel/87v97fccq9.ffs@xxxxxxxxxxxxxxxxxxxxxxx/ 
>
>
> At some stage the irq_set_affinity_hint() calls need to be fixed up here 
> as well.
Hi John,

Seems irq_set_affinity_hint() need to be replaced by irq_set_affinity(). 
I'll fix this and send a new version latter.

Thanks,
Qi
> Thanks,
> John
>
> .