[PATCH 4.9 066/240] dm space map common: fix division bug in sm_ll_find_free_block()

From: Greg Kroah-Hartman
Date: Thu May 20 2021 - 07:09:05 EST


From: Joe Thornber <ejt@xxxxxxxxxx>

commit 5208692e80a1f3c8ce2063a22b675dd5589d1d80 upstream.

This division bug meant the search for free metadata space could skip
the final allocation bitmap's worth of entries. Fix affects DM thinp,
cache and era targets.

Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Joe Thornber <ejt@xxxxxxxxxx>
Tested-by: Ming-Hung Tsai <mtsai@xxxxxxxxxx>
Signed-off-by: Mike Snitzer <snitzer@xxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/md/persistent-data/dm-space-map-common.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/md/persistent-data/dm-space-map-common.c
+++ b/drivers/md/persistent-data/dm-space-map-common.c
@@ -337,6 +337,8 @@ int sm_ll_find_free_block(struct ll_disk
*/
begin = do_div(index_begin, ll->entries_per_block);
end = do_div(end, ll->entries_per_block);
+ if (end == 0)
+ end = ll->entries_per_block;

for (i = index_begin; i < index_end; i++, begin = 0) {
struct dm_block *blk;