[PATCH] regulator: fixed: Ensure enable_counter is correct if reg_domain_disable fails

From: Axel Lin
Date: Thu May 20 2021 - 08:22:22 EST


dev_pm_genpd_set_performance_state() may fail, so had better to check it's
return value before decreasing priv->enable_counter.

Fixes: bf3a28cf4241 ("regulator: fixed: support using power domain for enable/disable")
Signed-off-by: Axel Lin <axel.lin@xxxxxxxxxx>
---
drivers/regulator/fixed.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index 02ad83153e19..34e255c235d4 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -88,10 +88,15 @@ static int reg_domain_disable(struct regulator_dev *rdev)
{
struct fixed_voltage_data *priv = rdev_get_drvdata(rdev);
struct device *dev = rdev->dev.parent;
+ int ret;
+
+ ret = dev_pm_genpd_set_performance_state(dev, 0);
+ if (ret)
+ return ret;

priv->enable_counter--;

- return dev_pm_genpd_set_performance_state(dev, 0);
+ return 0;
}

static int reg_is_enabled(struct regulator_dev *rdev)
--
2.25.1