RE: [PATCH 07/38] drm/sti/sti_hda: Provide missing function names

[Fabien DESSENNE]

Hi Lee

Thank you for the patch

BR
Fabien


ST Restricted

> -----Original Message-----
> From: Lee Jones <lee.jones@xxxxxxxxxx>
> Sent: jeudi 20 mai 2021 14:02
> To: lee.jones@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Benjamin Gaignard
> <benjamin.gaignard@xxxxxxxxxx>; David Airlie <airlied@xxxxxxxx>; Daniel Vetter
> <daniel@xxxxxxxx>; Fabien DESSENNE <fabien.dessenne@xxxxxx>; dri-
> devel@xxxxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 07/38] drm/sti/sti_hda: Provide missing function names
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/gpu/drm/sti/sti_hda.c:283: warning: expecting prototype for Search for
> a video mode in the supported modes table(). Prototype was for
> hda_get_mode_idx() instead
>  drivers/gpu/drm/sti/sti_hda.c:301: warning: expecting prototype for Enable the
> HD DACS(). Prototype was for hda_enable_hd_dacs() instead
>  drivers/gpu/drm/sti/sti_hda.c:383: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> 
> Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Daniel Vetter <daniel@xxxxxxxx>
> Cc: Fabien Dessenne <fabien.dessenne@xxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
Reviewed-by: Fabien Dessenne <fabien.dessenne@xxxxxxxxxxx>

> ---
>  drivers/gpu/drm/sti/sti_hda.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c index
> 5c2b650b561d5..03f3377f918c0 100644
> --- a/drivers/gpu/drm/sti/sti_hda.c
> +++ b/drivers/gpu/drm/sti/sti_hda.c
> @@ -272,7 +272,7 @@ static void hda_write(struct sti_hda *hda, u32 val, int
> offset)  }
> 
>  /**
> - * Search for a video mode in the supported modes table
> + * hda_get_mode_idx - Search for a video mode in the supported modes
> + table
>   *
>   * @mode: mode being searched
>   * @idx: index of the found mode
> @@ -292,7 +292,7 @@ static bool hda_get_mode_idx(struct
> drm_display_mode mode, int *idx)  }
> 
>  /**
> - * Enable the HD DACS
> + * hda_enable_hd_dacs - Enable the HD DACS
>   *
>   * @hda: pointer to HD analog structure
>   * @enable: true if HD DACS need to be enabled, else false @@ -380,7 +380,7
> @@ static void hda_debugfs_init(struct sti_hda *hda, struct drm_minor *minor)
> }
> 
>  /**
> - * Configure AWG, writing instructions
> + * sti_hda_configure_awg - Configure AWG, writing instructions
>   *
>   * @hda: pointer to HD analog structure
>   * @awg_instr: pointer to AWG instructions table
> --
> 2.31.1