Re: [PATCH RESEND v2 2/7] PCI: Add pcie_reset_flr to follow calling convention of other reset methods

[Krzysztof Wilczyński]

Hi Amey,

[...]
> +int pcie_reset_flr(struct pci_dev *dev, int probe)
> +{
> +	u32 cap;
> +
> +	if (dev->dev_flags & PCI_DEV_FLAGS_NO_FLR_RESET)
> +		return -ENOTTY;
> +
> +	pcie_capability_read_dword(dev, PCI_EXP_DEVCAP, &cap);
> +	if (!(cap & PCI_EXP_DEVCAP_FLR))
> +		return -ENOTTY;
> +
> +	if (probe)
> +		return 0;
> +
> +	return pcie_flr(dev);
> +}

Similarly to my suggestion in the first patch in the series, perhaps
using a boolean here would be an option.

Having said that, the following existing functions aren't doing it, so
for the sake of keeping things consistent it might not be the best
option, as per:

 static int pci_af_flr(struct pci_dev *dev, int probe)
 int nvme_disable_and_flr(struct pci_dev *dev, int probe)

Krzysztof