Re: [PATCH v2] Documentation: checkpatch: Tweak BIT() macro include

From: Joel Stanley
Date: Thu May 20 2021 - 20:59:40 EST


On Thu, 20 May 2021 at 17:14, Andrew Jeffery <andrew@xxxxxxxx> wrote:
>
> While include/linux/bitops.h brings in the BIT() macro, it was moved to
> include/linux/bits.h in commit 8bd9cb51daac ("locking/atomics, asm-generic:
> Move some macros from <linux/bitops.h> to a new <linux/bits.h> file").
>
> Since that commit BIT() has moved again into include/vdso/bits.h via
> commit 3945ff37d2f4 ("linux/bits.h: Extract common header for vDSO").
>
> I think the move to the vDSO header can be considered an implementation
> detail, so for now update the checkpatch documentation to recommend use
> of include/linux/bits.h.
>
> Cc: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Acked-by: Jiri Slaby <jirislaby@xxxxxxxxxx>
> Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>

Reviewed-by: Joel Stanley <joel@xxxxxxxxx>

...just a little bit