Re: [PATCH 05/16] char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues

[Greg Kroah-Hartman]

On Thu, May 20, 2021 at 01:13:36PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/char/pcmcia/synclink_cs.c:4068: warning: Function parameter or member 'dev' not described in 'hdlcdev_ioctl'
>  drivers/char/pcmcia/synclink_cs.c:4068: warning: Function parameter or member 'ifr' not described in 'hdlcdev_ioctl'
>  drivers/char/pcmcia/synclink_cs.c:4068: warning: Function parameter or member 'cmd' not described in 'hdlcdev_ioctl'
>  drivers/char/pcmcia/synclink_cs.c:4068: warning: expecting prototype for called by network layer to process IOCTL call to network device(). Prototype was for hdlcdev_ioctl() instead
>  drivers/char/pcmcia/synclink_cs.c:4173: warning: Function parameter or member 'txqueue' not described in 'hdlcdev_tx_timeout'
> 
> Cc: Lee Jones <lee.jones@xxxxxxxxxx>
> Cc: paulkf@xxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>
> Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/char/pcmcia/synclink_cs.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/char/pcmcia/synclink_cs.c b/drivers/char/pcmcia/synclink_cs.c
> index 4a1e63911b279..b004abac61542 100644
> --- a/drivers/char/pcmcia/synclink_cs.c
> +++ b/drivers/char/pcmcia/synclink_cs.c
> @@ -4054,11 +4054,12 @@ static int hdlcdev_close(struct net_device *dev)
>  }
>  
>  /**
> - * called by network layer to process IOCTL call to network device
> + * hdlcdev_ioctl() - called by network layer to process IOCTL call
> + *                   to network device
>   *
> - * dev  pointer to network device structure
> - * ifr  pointer to network interface request structure
> - * cmd  IOCTL command code
> + * @dev:  pointer to network device structure
> + * @ifr:  pointer to network interface request structure
> + * @cmd:  IOCTL command code
>   *
>   * returns 0 if success, otherwise error code
>   */
> @@ -4165,7 +4166,8 @@ static int hdlcdev_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
>   * hdlcdev_tx_timeout() - called by network layer when transmit timeout
>   *                        is detected
>   *
> - * @dev:  pointer to network device structure
> + * @dev:      pointer to network device structure
> + * @txqueue:  unused
>   */
>  static void hdlcdev_tx_timeout(struct net_device *dev, unsigned int txqueue)
>  {
> -- 
> 2.31.1
> 

This one did not apply to my tree :(