Re: [PATCH 3/5] staging: media: atomisp: code formatting changes sh_css_params.c

[Dan Carpenter]

On Sat, May 01, 2021 at 12:16:07PM +0530, Deepak R Varma wrote:
> @@ -1562,8 +1544,10 @@ ia_css_isp_3a_statistics_map_allocate(
>  	base_ptr = me->data_ptr;
>  
>  	me->size = isp_stats->size;
> -	/* GCC complains when we assign a char * to a void *, so these
> -	 * casts are necessary unfortunately. */
> +	/*
> +	 * GCC complains when we assign a char * to a void *, so these
> +	 * casts are necessary unfortunately.
> +	 */

Not related to your patch, but assigning a char pointer to a void
pointer is fine and GCC will not complain.  The problem is that
me->dmem_stats is not a void pointer.  Someone should delete that
nonsense comment.

>  	me->dmem_stats    = (void *)base_ptr;
>  	me->vmem_stats_hi = (void *)(base_ptr + isp_stats->dmem_size);
>  	me->vmem_stats_lo = (void *)(base_ptr + isp_stats->dmem_size +

regards,
dan carpenter