Re: [RESEND PATCH V4 3/8] arm64: dts: qcom: pm7325: Add pm7325 base dts file

[skakit]

On 2021-05-20 12:50, Vinod Koul wrote:
> On 20-05-21, 12:02, skakit@xxxxxxxxxxxxxx wrote:
> > On 2021-05-18 22:12, Matthias Kaehlcke wrote:
> > > On Tue, May 18, 2021 at 05:16:27PM +0530, Vinod Koul wrote:
> > > > On 18-05-21, 11:50, satya priya wrote:
> > > > > Add base DTS file for pm7325 along with GPIOs and temp-alarm nodes.
> > > > >
> > > > > Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
> > > > > Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> > > > > ---
> > > > > Changes in RESEND V4:
> > > > >  - No Changes.
> > > > >
> > > > >  arch/arm64/boot/dts/qcom/pm7325.dtsi | 53 ++++++++++++++++++++++++++++++++++++
> > > > >  1 file changed, 53 insertions(+)
> > > > >  create mode 100644 arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/qcom/pm7325.dtsi b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > > new file mode 100644
> > > > > index 0000000..e7f64a9
> > > > > --- /dev/null
> > > > > +++ b/arch/arm64/boot/dts/qcom/pm7325.dtsi
> > > > > @@ -0,0 +1,53 @@
> > > > > +// SPDX-License-Identifier: BSD-3-Clause
> > > > > +// Copyright (c) 2021, The Linux Foundation. All rights reserved.
> > > > > +
> > > > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > > > +#include <dt-bindings/spmi/spmi.h>
> > > > > +
> > > > > +&spmi_bus {
> > > > > +	pm7325: pmic@1 {
> > > > > +		compatible = "qcom,pm7325", "qcom,spmi-pmic";
> > > >
> > > > where is qcom,pm7325 documented?
> >
> > >
> > > good point, I missed that one.
> > >
> >
> > Actually this point was discussed during V2(
> > https://lore.kernel.org/patchwork/patch/1406186/#1607321 ).
> > As far as I understand it is not mandatory to add "qcom,pm7325" as we 
> > are
> > adding "qcom,spmi-pmic". It is just a good to have change.
> > I could not find the documentation for pm8350c, pmk8350 and pmr735a as 
> > well.
>
> Yes that is a miss too, IMO all of these should be added to
> Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.txt or the yaml
> file replacing this

Okay, will add those four pmics to qcom,spmi-pmic.txt.

> Thanks