Re: [PATCH mfd v1] mfd: Add Renesas Synchronization Management Unit (SMU) support

[Lee Jones]

On Fri, 21 May 2021, Min Li wrote:

> > >
> > > +config MFD_RSMU_I2C
> > > +	tristate "Renesas Synchronization Management Unit with I2C"
> > > +	depends on I2C && OF
> > > +	depends on MFD_RSMU_SPI=n
> > 
> > Not sure I've seen a relationship like this before.
> > 
> > Devices capable of SPI and I2C usually have a core driver which selects one
> > or the other.  It will also save some code duplication you have here.  Please
> > take a look at some other examples in the MFD subsystem.
> 
> 
> Hi Lee
> 
> Thanks for taking your time to review my code. I will start working on the core driver. But
> Kconfig items will stay as MFD_RSMU_I2C and MFD_RSMU_SPI like the existing ones 
> 
> MFD_MADERA_SPI
> MFD_MADERA_I2C

And MFD_MADERA

> MFD_DA9052_SPI
> MFD_DA9052_I2C

And PMIC_DA9052

> MFD_MC13XXX_SPI
> MFD_MC13XXX_I2C

And MFD_MC13XXX

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog