Re: [PATCH 0/3] drm/msm/dp: Simplify aux code

[khsieh]

On 2021-05-21 14:57, Stephen Boyd wrote:
> Quoting Stephen Boyd (2021-05-07 14:25:02)
> > Here's a few patches that simplify the aux handling code and bubble up
> > timeouts and nacks to the upper DRM layers. The goal is to get DRM to
> > know that the other side isn't there or that there's been a timeout,
> > instead of saying that everything is fine and putting some error 
> > message
> > into the logs.
> >
> > Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Cc: Abhinav Kumar <abhinavk@xxxxxxxxxxxxxx>
> > Cc: Kuogee Hsieh <khsieh@xxxxxxxxxxxxxx>
> > Cc: aravindh@xxxxxxxxxxxxxx
> > Cc: Sean Paul <sean@xxxxxxxxxx>
>
> Kuogee, have you had a change to review this series?
Sorry  missed this one.
Will review it now.
> > Stephen Boyd (3):
> >   drm/msm/dp: Simplify aux irq handling code
> >   drm/msm/dp: Shrink locking area of dp_aux_transfer()
> >   drm/msm/dp: Handle aux timeouts, nacks, defers
> >
> >  drivers/gpu/drm/msm/dp/dp_aux.c     | 181 
> > ++++++++++++----------------
> >  drivers/gpu/drm/msm/dp/dp_aux.h     |   8 --
> >  drivers/gpu/drm/msm/dp/dp_catalog.c |   2 +-
> >  drivers/gpu/drm/msm/dp/dp_catalog.h |   2 +-
> >  4 files changed, 80 insertions(+), 113 deletions(-)
> >
> >
> > base-commit: 51595e3b4943b0079638b2657f603cf5c8ea3a66
> > --
> > https://chromeos.dev