[Resend] [PATCH 0/2] [RFC] staging: rtl8723bs: refactor to reduce indents
From: Shreyansh Chouhan
Date: Sat May 22 2021 - 05:20:36 EST
**RESENT THE PATCH BECAUSE I MESSED UP THE EMAIL ADDRESS FOR LKML IN THE
PREVIOUS MAIL. SORRY.**
This patch series tries to fix the following warnings by checkpatch.pl
in core/rtw_wlan_util.c:
WARNING: Too many leading tabs - consider code refactoring
#887: FILE: rtw_wlan_util.c:887:
+ if ((edca[j] >> 16) > (edca[i] >> 16))
WARNING: Too many leading tabs - consider code refactoring
#1529: FILE: rtw_wlan_util.c:1529:
+ if (pIE->data[5] & RT_HT_CAP_USE_92SE)
WARNING: Too many leading tabs - consider code refactoring
#1537: FILE: rtw_wlan_util.c:1537:
+ if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_BCUT)
WARNING: Too many leading tabs - consider code refactoring
#1540: FILE: rtw_wlan_util.c:1540:
+ if (pIE->data[6] & RT_HT_CAP_USE_JAGUAR_CCUT)
I wanted to ask for comments on the names of these functions and if such
a patch series would be acceptable.
The first patch refactors the code by introducing two new functions
sort_wmm_ac_params and get_realtek_assoc_AP_vender.
The second patch removes unnecessary braces from the conditional
statements in check_assoc_AP function.
Shreyansh Chouhan (2):
staging: rtl8723bs: refactor to reduce indents
staging: rtl8723bs: remove unnecessary braces from conditionals
.../staging/rtl8723bs/core/rtw_wlan_util.c | 141 +++++++++---------
1 file changed, 72 insertions(+), 69 deletions(-)
--
2.31.1