Re: [PATCH 11/24] scsi: sun3_scsi: remove leading spaces before tabs

From: Finn Thain
Date: Sat May 22 2021 - 18:37:50 EST



On Sat, 22 May 2021, Hui Tang wrote:

> There are a few leading spaces before tabs and remove it by running
> the following commard:
>
> $ find . -name '*.[ch]' | xargs sed -r -i 's/^[ ]+\t/\t/'
>

Acked-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Is there a reason why your regexp is anchored? I thought spaces before any
tab would be undesirable.

> Cc: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Hui Tang <tanghui20@xxxxxxxxxx>
> ---
> drivers/scsi/sun3_scsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sun3_scsi.c b/drivers/scsi/sun3_scsi.c
> index 2e3fbc2..6125ed3 100644
> --- a/drivers/scsi/sun3_scsi.c
> +++ b/drivers/scsi/sun3_scsi.c
> @@ -304,7 +304,7 @@ static int sun3scsi_dma_setup(struct NCR5380_hostdata *hostdata,
> sun3_udc_write(UDC_INT_ENABLE, UDC_CSR);
> #endif
>
> - return count;
> + return count;
>
> }
>
>