Re: [PATCH] mmc: mediatek: remove useless data parameter from msdc_data_xfer_next()

From: Ulf Hansson
Date: Mon May 24 2021 - 10:11:27 EST


On Mon, 17 May 2021 at 12:54, Yue Hu <zbestahu@xxxxxxxxx> wrote:
>
> From: Yue Hu <huyue2@xxxxxxxxxx>
>
> We do not use the 'data' in msdc_data_xfer_next().
>
> Signed-off-by: Yue Hu <huyue2@xxxxxxxxxx>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/mtk-sd.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index c4db944..4dfc246 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -1347,8 +1347,7 @@ static void msdc_post_req(struct mmc_host *mmc, struct mmc_request *mrq,
> }
> }
>
> -static void msdc_data_xfer_next(struct msdc_host *host,
> - struct mmc_request *mrq, struct mmc_data *data)
> +static void msdc_data_xfer_next(struct msdc_host *host, struct mmc_request *mrq)
> {
> if (mmc_op_multi(mrq->cmd->opcode) && mrq->stop && !mrq->stop->error &&
> !mrq->sbc)
> @@ -1407,7 +1406,7 @@ static bool msdc_data_xfer_done(struct msdc_host *host, u32 events,
> (int)data->error, data->bytes_xfered);
> }
>
> - msdc_data_xfer_next(host, mrq, data);
> + msdc_data_xfer_next(host, mrq);
> done = true;
> }
> return done;
> --
> 1.9.1
>