Re: [PATCH -next] module: fix build error when CONFIG_SYSFS is disabled

From: Bixuan Cui
Date: Tue May 25 2021 - 04:28:18 EST




On 2021/5/25 15:36, Stephen Boyd wrote:
> Quoting Bixuan Cui (2021-05-25 01:54:00)
>> kernel/module.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/kernel/module.c b/kernel/module.c
>> index decf4601e943..7287ecc76714 100644
>> --- a/kernel/module.c
>> +++ b/kernel/module.c
>> @@ -2794,7 +2794,8 @@ static void add_kallsyms(struct module *mod, const struct load_info *info)
>> }
>> #endif /* CONFIG_KALLSYMS */
>>
>> -#if IS_ENABLED(CONFIG_KALLSYMS) && IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
>> +#if IS_ENABLED(CONFIG_KALLSYMS) && IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID) && \
>> + IS_ENABLED(CONFIG_SYSFS)
> Thanks for the report. It is the wrong fix though as we don't care that
> sysfs is enabled or not. How about this patch?
Hello, your patch solves that problem very well. Will you send a new patch?

Thanks
Bixuan Cui