RE: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations

[Joakim Zhang]

Hi Andrew,

> -----Original Message-----
> From: Andrew Lunn <andrew@xxxxxxx>
> Sent: 2021年5月23日 22:39
> To: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; frieder.schrempf@xxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx
> <linux-imx@xxxxxxx>
> Subject: Re: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX
> bandwidth fluctuations
> 
> > @@ -76,6 +76,8 @@ static void fec_enet_itr_coal_init(struct net_device
> *ndev);
> >
> >  #define DRIVER_NAME	"fec"
> >
> > +static const u16 fec_enet_vlan_pri_to_queue[8] = {1, 1, 1, 1, 2, 2, 2, 2};
> 
> I wonder if priority 0 should be sent to queue 0?

Yes, we can. But the original thought of author seems to, VLAN tagged packets only use queue 1&2, and queue 0is reserved for VLAN untagged packets.

Best Regards,
Joakim Zhang
>   Andrew