Re: [PATCH v2 1/3] PM / EM: Fix inefficient state detection

From: Quentin Perret
Date: Tue May 25 2021 - 05:50:50 EST


On Friday 21 May 2021 at 17:54:22 (+0100), Vincent Donnefort wrote:
> Currently, a debug message is printed if an inefficient state is detected
> in the Energy Model. Unfortunately, it won't detect if the first state is
> inefficient or if two successive states are. Fix this behavior.

Right, and the first OPPs in the table often are the inefficient ones
(because e.g. they share the same voltage), so this definitely wants
fixing. I wonder if this wants a Fixes: tag even?

> Signed-off-by: Vincent Donnefort <vincent.donnefort@xxxxxxx>

Reviewed-by: Quentin Perret <qperret@xxxxxxxxxx>

Thanks,
Quentin