Re: [PATCH v6 1/4] string_helpers: Escape double quotes in escape_special

From: Petr Mladek
Date: Tue May 25 2021 - 06:17:19 EST


On Tue 2021-05-18 13:00:32, Chris Down wrote:
> >From an abstract point of view, escape_special's counterpart,

The first line starts with '<'. I guess that it is a typo ;-)

> unescape_special, already handles the unescaping of blackslashed double
> quote sequences.

Yup. Makes sense.

> Signed-off-by: Chris Down <chris@xxxxxxxxxxxxxx>
> Cc: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Cc: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

I agree with Andy that you should double check the existing users and
add a note that none is affected.

With it, feel free to add:

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

Best Regards,
Petr