Re: [PATCH v2] memcontrol: use flexible-array member

[Michal Hocko]

On Tue 18-05-21 16:09:08, wenhuizhang wrote:
> Change depracated zero-length-and-one-element-arrays into flexible
> array member.Zero-length and one-element arrays detected by Lukas's CodeChecker.
> Zero/one element arrays causes undefined behaviours if sizeof() used.
> 
> Signed-off-by: wenhuizhang <wenhui@xxxxxxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>

Thanks!
> ---
>  include/linux/memcontrol.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index 0ce97eff79e2..3cc18c2176e7 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -349,8 +349,7 @@ struct mem_cgroup {
>  	struct deferred_split deferred_split_queue;
>  #endif
>  
> -	struct mem_cgroup_per_node *nodeinfo[0];
> -	/* WARNING: nodeinfo must be the last member here */
> +	struct mem_cgroup_per_node *nodeinfo[];
>  };
>  
>  /*
> -- 
> 2.17.1

-- 
Michal Hocko
SUSE Labs