Re: Patch regression - Re: [PATCH 5.10 070/104] dm snapshot: fix a crash when an origin has no snapshots

From: Mikulas Patocka
Date: Tue May 25 2021 - 07:58:27 EST




On Tue, 25 May 2021, Greg Kroah-Hartman wrote:

> On Tue, May 25, 2021 at 07:36:57AM -0400, Mikulas Patocka wrote:
> > Hi Greg
> >
> > I'd like to ask you to drop this patch from all stable branches.
> >
> > It causes regression with snapshot merging and the regression is much
> > worse than the bug that it fixes.
>
> Sure, but is there a fix in Linus's branch for this that I should take
> instead, or is it reverted in linux-next already?
>
> thanks,
>
> greg k-h

There is no fix now - but the bug that this fixed is minor (it fixes a
crash in a configuration that is never set by lvm2) - and the regression
is major (snapshot merging doesn't work).

I'll work with Mike on reverting it a providing a proper fix.

Mikulas