Re: [RFC 06/26] mm, slub: dissolve new_slab_objects() into ___slab_alloc()

From: Mel Gorman
Date: Tue May 25 2021 - 08:00:07 EST


On Tue, May 25, 2021 at 01:39:26AM +0200, Vlastimil Babka wrote:
> The later patches will need more fine grained control over individual actions
> in ___slab_alloc(), the only caller of new_slab_objects(), so dissolve it
> there. This is a preparatory step with no functional change.
>
> The only minor change is moving WARN_ON_ONCE() for using a constructor together
> with __GFP_ZERO to new_slab() which makes it somewhat less frequent, but still
> able to catch a misuse.
>
> Signed-off-by: Vlastimil Babka <vbabka@xxxxxxx>

The goto in the previous patch makes a bit more sense now

Acked-by: Mel Gorman <mgorman@xxxxxxxxxxxxxxxxxxx>

--
Mel Gorman
SUSE Labs