Re: [PATCH v29 05/13] mm/damon: Implement primitives for the virtual memory address spaces

From: sieberf
Date: Tue May 25 2021 - 11:19:54 EST


Hi SeongJae,

Some questions for this patch:

Why do we split the regions in 3 areas (heap, stack, mmaped)? I understand we don't want to model the whole virtual address space, but why don't we just use whatever is modeled by the VMAs to define the regions boundaries?

I am not quite understanding why we both set the page idle and young (in damon_ptep_mkold). For WSS computation on our end we have used pte_clear_young_notify. Why do we touch the page idle flag at all? What flags do the reclaim logic use to track access?

Kind regards,

Fernand