Re: [PATCH v3 1/3] gpio: regmap: Support few IC specific operations
From: kernel test robot
Date: Tue May 25 2021 - 11:32:40 EST
Hi Matti,
I love your patch! Yet something to improve:
[auto build test ERROR on c4681547bcce777daf576925a966ffa824edd09d]
url: https://github.com/0day-ci/linux/commits/Matti-Vaittinen/gpio-gpio-regmap-Support-few-custom-operations/20210525-204554
base: c4681547bcce777daf576925a966ffa824edd09d
config: arm64-randconfig-r014-20210525 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/fac1c3d2b667e599ee2e3bba357847f9a35f43c7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matti-Vaittinen/gpio-gpio-regmap-Support-few-custom-operations/20210525-204554
git checkout fac1c3d2b667e599ee2e3bba357847f9a35f43c7
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/pinctrl/bcm/pinctrl-bcm63xx.c: In function 'bcm63xx_gpio_probe':
>> drivers/pinctrl/bcm/pinctrl-bcm63xx.c:59:5: error: 'struct gpio_regmap_config' has no member named 'reg_mask_xlate'
59 | grc.reg_mask_xlate = bcm63xx_reg_mask_xlate;
| ^
>> drivers/pinctrl/bcm/pinctrl-bcm63xx.c:61:25: error: too few arguments to function 'devm_gpio_regmap_register'
61 | return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &grc));
| ^~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/pinctrl/bcm/pinctrl-bcm63xx.c:9:
include/linux/gpio/regmap.h:105:21: note: declared here
105 | struct gpio_regmap *devm_gpio_regmap_register(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/pinctrl/bcm/pinctrl-bcm63xx.c:62:1: error: control reaches end of non-void function [-Werror=return-type]
62 | }
| ^
cc1: some warnings being treated as errors
vim +59 drivers/pinctrl/bcm/pinctrl-bcm63xx.c
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 44
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 45 static int bcm63xx_gpio_probe(struct device *dev, struct device_node *node,
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 46 const struct bcm63xx_pinctrl_soc *soc,
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 47 struct bcm63xx_pinctrl *pc)
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 48 {
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 49 struct gpio_regmap_config grc = {0};
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 50
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 51 grc.parent = dev;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 52 grc.fwnode = &node->fwnode;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 53 grc.ngpio = soc->ngpios;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 54 grc.ngpio_per_reg = BCM63XX_BANK_GPIOS;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 55 grc.regmap = pc->regs;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 56 grc.reg_dat_base = BCM63XX_DATA_REG;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 57 grc.reg_dir_out_base = BCM63XX_DIROUT_REG;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 58 grc.reg_set_base = BCM63XX_DATA_REG;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 @59 grc.reg_mask_xlate = bcm63xx_reg_mask_xlate;
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 60
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 @61 return PTR_ERR_OR_ZERO(devm_gpio_regmap_register(dev, &grc));
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 62 }
132f95016db0a0 Álvaro Fernández Rojas 2021-03-24 63
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip