Re: [PATCH v4 2/2] scsi: ufs-qcom: enter and exit hibern8 during clock scaling

[Asutosh Das (asd)]

On 5/25/2021 12:57 AM, Lee Jones wrote:
> On Wed, 20 May 2020 at 22:59, Asutosh Das (asd) <asutoshd@xxxxxxxxxxxxxx 
> <mailto:asutoshd@xxxxxxxxxxxxxx>> wrote:
>
>     Hi Avri,
>
>     On 5/20/2020 2:33 PM, Avri Altman wrote:
>      > Hi,
>      >
>      >>
>      >>
>      >> Qualcomm controller needs to be in hibern8 before scaling clocks.
>      >> This change puts the controller in hibern8 state before scaling
>      >> and brings it out after scaling of clocks.
>      >>
>      >> Signed-off-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx
>     <mailto:asutoshd@xxxxxxxxxxxxxx>>
>      >
>      > I guess that your previous versions are pretty far back - ,
>      > I noticed a comment by Pedro, so you might want to resend this
>     series.
>      >
>     Ok.
>
>      > What happens if the pre-change is successful,
>      > but you are not getting to the post change because, e.g.
>     ufshcd_set_clk_freq failed?
>      >
>     I agree. Let me check this.
>
>      > Also, this piece of code is ~5 years old, so you might want to
>     elaborate on how come hibernation is now needed.
>      >
>      > Thanks,
>      > Avri
>      >
>
>     Thanks for the review. Hibernation was needed since long actually.
>     I guess it was never pushed upstream.
>
>
> Good morning Asd,
>
> Any luck with getting this upstream?
>
> Looks like this was the last submission.
>
> Did something change?  Is this no longer required?
Hi Lee
This slipped away. I may not get to this soon.
I'd prefer to drop it for now and come back to it when I've some time.

Thanks,
-asd

> --
> Lee Jones [李琼斯]
> Linaro Services Senior Technical Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog


--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project