Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message

[Leizhen (ThunderTown)]

On 2021/5/26 10:32, Randy Dunlap wrote:
> On 5/25/21 7:18 PM, Zhen Lei wrote:
>> The misspelled word 'borken' should be 'broken'.
>>
>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>> ---
>>  kernel/sched/topology.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>> index 55a0a243e871..80295e224442 100644
>> --- a/kernel/sched/topology.c
>> +++ b/kernel/sched/topology.c
>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>  
>>  		if (!cpumask_subset(sched_domain_span(child),
>>  				    sched_domain_span(sd))) {
>> -			pr_err("BUG: arch topology borken\n");
>> +			pr_err("BUG: arch topology broken\n");
> 
> Would "borked" or "b0rken" be clearer?

These two words don't seem to exist at all. Linux is an open-source
code for the world, so it's better to use a more common word.

> 
>>  #ifdef CONFIG_SCHED_DEBUG
>>  			pr_err("     the %s domain not a subset of the %s domain\n",
>>  					child->name, sd->name);
>>
> 
> 
> I.e., this is misspelt on purpose.
> 
> Reply to a previous version of this patch:
>   https://lore.kernel.org/lkml/1493036801.6266.12.camel@xxxxxx/
> 
> cheers.
>