Re: [External] [PATCH 0/2] Track reserve map changes to restore on error

From: Muchun Song
Date: Tue May 25 2021 - 23:20:02 EST


On Wed, May 26, 2021 at 7:31 AM Mike Kravetz <mike.kravetz@xxxxxxxxxx> wrote:
>
> Here is a modification to the reservation tracking for fixup on errors.
> It is a more general change, but should work for the hugetlb_mcopy_pte_atomic
> case as well.
>
> Perhaps use this as a prerequisite for your fix(es)? Pretty sure this
> will eliminate the need for the call to hugetlb_unreserve_pages.

Hi Mike,

It seems like someone is fixing a bug, right? Maybe a link should be
placed in the cover letter so that someone can know what issue
we are facing.

Thanks.

>
> Mike Kravetz (2):
> hugetlb: rename HPageRestoreReserve flag to HPageRestoreRsvCnt
> hugetlb: add new hugetlb specific flag HPG_restore_rsv_map
>
> fs/hugetlbfs/inode.c | 3 +-
> include/linux/hugetlb.h | 17 +++++--
> mm/hugetlb.c | 108 ++++++++++++++++++++++++++++------------
> mm/userfaultfd.c | 14 +++---
> 4 files changed, 99 insertions(+), 43 deletions(-)
>
> --
> 2.31.1
>