Re: [PATCH] perf core: Fix some kernel-doc warnings.

From: Ingo Molnar
Date: Wed May 26 2021 - 03:05:41 EST



* Haocheng Xie <xiehaocheng.cn@xxxxxxxxx> wrote:

> Fix the following W=1 kernel build warning(s):
> kernel/events/core.c:143: warning: Function parameter or member 'cpu' not described in 'cpu_function_call'
> kernel/events/core.c:11924: warning: Function parameter or member 'flags' not described in 'sys_perf_event_open'
> kernel/events/core.c:12382: warning: Function parameter or member 'overflow_handler' not described in 'perf_event_create_kernel_counter'
> kernel/events/core.c:12382: warning: Function parameter or member 'context' not described in 'perf_event_create_kernel_counter'
>
> Signed-off-by: Haocheng Xie <xiehaocheng.cn@xxxxxxxxx>

Even with your two patches there's still W=1 warnings remaining in
kernel/events/:

kernel/events/hw_breakpoint.c:461: warning: Function parameter or member 'context' not described in 'register_user_hw_breakpoint'
kernel/events/hw_breakpoint.c:560: warning: Function parameter or member 'context' not described in 'register_wide_hw_breakpoint'

Could you please fix all of them, and send them as a 3-patch series?

Doesn't make much sense to just partially fix W=1 warnings in a subsystem.

Thanks,

Ingo