Re: linux-next: Tree for May 25 (x86: NR_CPUS undeclared)

From: Ingo Molnar
Date: Wed May 26 2021 - 03:08:50 EST



* Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 5/24/21 11:39 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20210524:
> >
>
> on x86_64, there can be +/- 100 build errors like so:
>
> ../arch/x86/include/asm/fixmap.h:103:48: error: 'NR_CPUS' undeclared here (not in a function); did you mean 'NR_OPEN'?
> FIX_KMAP_END = FIX_KMAP_BEGIN + (KM_MAX_IDX * NR_CPUS) - 1,
> ^~~~~~~
> NR_OPEN
>
> Fix is here:
> https://lore.kernel.org/lkml/20210521195918.2183-1-rdunlap@xxxxxxxxxxxxx/

This came into -next via a stray header dependencies patch in -mm.

I followed up in that thread, but I'm somewhat worried that the complexity
of header dependencies are not going in the right direction in that group
of headers. ;-)

Thanks,

Ingo