Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message

[Leizhen (ThunderTown)]

On 2021/5/26 14:57, Peter Zijlstra wrote:
> On Wed, May 26, 2021 at 10:42:31AM +0800, Leizhen (ThunderTown) wrote:
>>
>>
>> On 2021/5/26 10:32, Randy Dunlap wrote:
>>> On 5/25/21 7:18 PM, Zhen Lei wrote:
>>>> The misspelled word 'borken' should be 'broken'.
>>>>
>>>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>>>> ---
>>>>  kernel/sched/topology.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>>>> index 55a0a243e871..80295e224442 100644
>>>> --- a/kernel/sched/topology.c
>>>> +++ b/kernel/sched/topology.c
>>>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>>>  
>>>>  		if (!cpumask_subset(sched_domain_span(child),
>>>>  				    sched_domain_span(sd))) {
>>>> -			pr_err("BUG: arch topology borken\n");
>>>> +			pr_err("BUG: arch topology broken\n");
>>>
>>> Would "borked" or "b0rken" be clearer?
>>
>> These two words don't seem to exist at all. Linux is an open-source
>> code for the world, so it's better to use a more common word.
> 
> Language is a living thing; also:
> 
>   https://www.urbandictionary.com/define.php?term=borked

OK, I got it. Thanks.

> 
> I realize that as a non-native speaker idioms and colloquialisms are
> difficult, but if we sanitize the language we'll end up with something
> dreadfully dull and less expressive.
> 
> Also; this is a rather trivial play on words, to break the word broken,
> it should apply to pretty much any (written) language. It should be an
> evident pun to all except computer spell checkers (they so lack humour).
> 
> Also, I too am a non-native speaker, although I suspect I have it easier
> for my native tongue is at least in the same language group as English.
> 
> 
> .
>