Re: [PATCH v1 4/4] gpio: gpio-aspeed-sgpio: Add AST2600 sgpio support

[kernel test robot]

Hi Steven,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on joel-aspeed/for-next]
[also build test ERROR on robh/for-next gpio/for-next v5.13-rc3 next-20210526]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Steven-Lee/ASPEED-sgpio-driver-enhancement/20210526-174912
base:   https://git.kernel.org/pub/scm/linux/kernel/git/joel/aspeed.git for-next
config: powerpc64-randconfig-r021-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 99155e913e9bad5f7f8a247f8bb3a3ff3da74af1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install powerpc64 cross compiling tool for clang build
        # apt-get install binutils-powerpc64-linux-gnu
        # https://github.com/0day-ci/linux/commit/72b31f2c47f6ab3ce9a7115dcc0dc01331bf45c0
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Steven-Lee/ASPEED-sgpio-driver-enhancement/20210526-174912
        git checkout 72b31f2c47f6ab3ce9a7115dcc0dc01331bf45c0
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/gpio/gpio-aspeed-sgpio.c:183:57: error: use of undeclared identifier 'gpio'; did you mean 'goto'?
           const struct aspeed_sgpio_bank *bank = to_bank(offset, gpio->max_ngpios);
                                                                  ^~~~
                                                                  goto
>> drivers/gpio/gpio-aspeed-sgpio.c:183:57: error: expected expression
   drivers/gpio/gpio-aspeed-sgpio.c:201:57: error: use of undeclared identifier 'gpio'; did you mean 'goto'?
           const struct aspeed_sgpio_bank *bank = to_bank(offset, gpio->max_ngpios);
                                                                  ^~~~
                                                                  goto
   drivers/gpio/gpio-aspeed-sgpio.c:201:57: error: expected expression
   4 errors generated.


vim +183 drivers/gpio/gpio-aspeed-sgpio.c

   180	
   181	static int aspeed_sgpio_get(struct gpio_chip *gc, unsigned int offset)
   182	{
 > 183		const struct aspeed_sgpio_bank *bank = to_bank(offset, gpio->max_ngpios);
   184		struct aspeed_sgpio *gpio = gpiochip_get_data(gc);
   185		unsigned long flags;
   186		enum aspeed_sgpio_reg reg;
   187		int rc = 0;
   188	
   189		spin_lock_irqsave(&gpio->lock, flags);
   190	
   191		reg = aspeed_sgpio_is_input(offset, gpio->max_ngpios) ? reg_val : reg_rdata;
   192		rc = !!(ioread32(bank_reg(gpio, bank, reg)) & GPIO_BIT(offset % gpio->max_ngpios));
   193	
   194		spin_unlock_irqrestore(&gpio->lock, flags);
   195	
   196		return rc;
   197	}
   198	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip