Re: [PATCH 03/24] usb: common: ulpi: Add leading underscores for function name '__ulpi_register_driver()'

[Heikki Krogerus]

On Wed, May 26, 2021 at 02:00:16PM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/usb/common/ulpi.c:151: warning: expecting prototype for ulpi_register_driver(). Prototype was for __ulpi_register_driver() instead
> 
> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: linux-usb@xxxxxxxxxxxxxxx
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>

> ---
>  drivers/usb/common/ulpi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/common/ulpi.c b/drivers/usb/common/ulpi.c
> index ce5e6f6711f79..7e13b74e60e5a 100644
> --- a/drivers/usb/common/ulpi.c
> +++ b/drivers/usb/common/ulpi.c
> @@ -141,7 +141,7 @@ static const struct device_type ulpi_dev_type = {
>  /* -------------------------------------------------------------------------- */
>  
>  /**
> - * ulpi_register_driver - register a driver with the ULPI bus
> + * __ulpi_register_driver - register a driver with the ULPI bus
>   * @drv: driver being registered
>   * @module: ends up being THIS_MODULE
>   *
> -- 
> 2.31.1

-- 
heikki