Re: [PATCH][next] acpi: power: remove redundant initialization of variable result

[Rafael J. Wysocki]

On Wed, May 26, 2021 at 4:12 PM Colin King <colin.king@xxxxxxxxxxxxx> wrote:
>
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The variable result is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  drivers/acpi/power.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index 97c9a94a1a30..d86865c04f64 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -919,7 +919,7 @@ struct acpi_device *acpi_add_power_resource(acpi_handle handle)
>         union acpi_object acpi_object;
>         struct acpi_buffer buffer = { sizeof(acpi_object), &acpi_object };
>         acpi_status status;
> -       int state, result = -ENODEV;
> +       int state, result;
>
>         acpi_bus_get_device(handle, &device);
>         if (device)
> --

Equivalent change is made in

https://patchwork.kernel.org/project/linux-acpi/patch/2786380.e9J7NaK4W3@kreacher/

Thanks!