Re: [PATCH v2] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume

From: Jiri Kosina
Date: Wed May 26 2021 - 10:45:14 EST


On Wed, 26 May 2021, Srinivas Pandruvada wrote:

> > > The individual sensor drivers implemented in the ISH firmware needs
> > > capability to take special actions when there is a change in the
> > > system standby state. The ISH core firmware passes this notification
> > > to individual sensor drivers in response to the OS request via
> > > connected standby bit in the SYSTEM_STATE_STATUS command.
> > >
> > > This change sets CONNECTED_STANDBY_STATE_BIT bit to 1 during
> > > suspend
> > > callback and clears during resume callback.
> > >
> > > Signed-off-by: Ye Xiang <xiang.ye@xxxxxxxxx>
> > > [srinivas.pandruvada@xxxxxxxxxxxxxxx: changelog rewrite]
> > > Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > > ---
> > > v2:
> > > changed changelog to be more clear
> > > Changed the name in the signed-off to match "From"
> > >
> > > drivers/hid/intel-ish-hid/ishtp/hbm.c | 6 +++---
> > > drivers/hid/intel-ish-hid/ishtp/hbm.h | 1 +
> > > 2 files changed, 4 insertions(+), 3 deletions(-)
> >
> > Applied, thanks.
>
> I don't see this patch in 5.13-rc3. But I see in linux-next. There are
> other patches here which didn't make to 5.13-rc.
>
> I see them in
> https://kernel.googlesource.com/pub/scm/linux/kernel/git/hid/hid/+/refs/heads/for-5.13/intel-ish
>
> Did you decide to postpone for 5.14?

Uwe Kleine-Koening already noticed this:

http://lore.kernel.org/r/nycvar.YFH.7.76.2105131318120.28378@xxxxxxxxxxxxx

I apologize for the hassle.

> It will be fine to postpone.

Thanks. It's currently in for-5.14/intel-ish.

--
Jiri Kosina
SUSE Labs