Re: [PATCH v7 1/3] perf report: compile tips.txt in perf binary

[Denys Zagorui -X (dzagorui - GLOBALLOGIC INC at Cisco)]

> [perfbuilder@five ~]$ export PERF_TARBALL=http://192.168.100.2/perf/perf-5.13.0-rc3.tar.xz
> [perfbuilder@five ~]$ time dm
> Wed May 26 11:04:00 AM -03 2021
> # export PERF_TARBALL=http://192.168.100.2/perf/perf-5.13.0-rc3.tar.xz
> # dm
>   1     9.39 alpine:3.4                    : FAIL gcc version 5.3.0 (Alpine 5.3.0)
>    builtin-report.c: In function 'cmd_report':
>    builtin-report.c:560:3: error: 'prev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>       fprintf(stdout, "#\n# (%s)\n#\n", help);
>       ^
>    builtin-report.c:622:20: note: 'prev' was declared here
>      char *tok, *tmp, *prev;
> <SNIP>
>
>  10    13.35 alpine:3.13                   : FAIL gcc version 10.2.1 20201203 (Alpine 10.2.1_pre1)
>    builtin-report.c: In function 'cmd_report':
>    builtin-report.c:560:3: error: 'prev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      560 |   fprintf(stdout, "#\n# (%s)\n#\n", help);
>          |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    builtin-report.c:622:20: note: 'prev' was declared here
>      622 |  char *tok, *tmp, *prev;
>          |                    ^~~~
>    cc1: all warnings being treated as errors
>  11    13.77 alpine:edge                   : FAIL gcc version 10.3.1 20210424 (Alpine 10.3.1_git20210424)
>    builtin-report.c: In function 'cmd_report':
>    builtin-report.c:560:3: error: 'prev' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>      560 |   fprintf(stdout, "#\n# (%s)\n#\n", help);
>          |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    builtin-report.c:622:20: note: 'prev' was declared here
>      622 |  char *tok, *tmp, *prev;
>          |                    ^~~~
>    cc1: all warnings being treated as errors
>
>
> I'll check later...

prev should be initialized to _binary_Documentation_tips_txt_start, i can resend 


Thanks,
Denys