Re: [PATCH] cpufreq: intel_pstate: hybrid: Fix build with CONFIG_ACPI unset

From: Rafael J. Wysocki
Date: Wed May 26 2021 - 13:12:50 EST


On Wed, May 26, 2021 at 6:10 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> On 5/26/21 8:01 AM, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
> >
> > One of the previous commits introducing hybrid processor support to
> > intel_pstate broke build with CONFIG_ACPI unset.
> >
> > Fix that and while at it fix up empty stubs of two functions related
> > to ACPI CPPC.
> >
> > Fixes: eb3693f0521e ("cpufreq: intel_pstate: hybrid: CPU-specific scaling factor")
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Hi Rafael,
>
> I still have this build error:
>
> ../drivers/cpufreq/intel_pstate.c: In function ‘show_base_frequency’:
> ../drivers/cpufreq/intel_pstate.c:950:10: error: implicit declaration of function ‘intel_pstate_get_cppc_guranteed’; did you mean ‘intel_pstate_get_epp’? [-Werror=implicit-function-declaration]
> ratio = intel_pstate_get_cppc_guranteed(policy->cpu);

Well, I did too much in this patch, will send an update shortly.

> BTW: s/guranteed/guaranteed/g

Right.