Re: [PATCH 00/10] Add support for older Rockchip SoCs to V4L2 hantro and rkvdec drivers

[Alex Bee]

Hi Heiko, Ezequiel, Rob and List,

thanks for your feedback.

Am 26.05.21 um 01:01 schrieb Heiko Stübner:
> Hi Alex,
>
> Am Dienstag, 25. Mai 2021, 17:22:15 CEST schrieb Alex Bee:
> > Hi list,
> >
> > this series adds support for older Rockchip SoCs (RK3036, RK3066, RK3188
> > and RK322x) to the existing V4L2 video decoder/-encoder drivers - namely
> > hantro and rkvdec.
> > They can be used as-is or with very little modifications.
> >
> > In preparation to that patches 1-3 add power-controller support for RK3036
> > and RK322x, since both drivers rely on pm. The drivers for them exist
> > already in the common Rockchip pm driver, they just haven't be added to
> > the device trees yet.
> on first glance, looks good. Just a small ordering nit, if you need to resend
> the series for other reasons:
>
> Please try to order patches like:
> (1) dt-binding - compatible addition
> (2) driver patches
> (3) devicetree node patches
>
> That makes it way easier to keep track of dependencies when glancing at
> the series. Like for patches 1+2, I need to wait for Lee to apply (or Ack) the
> binding addition in patch 3.
>
> Same for the hantro devicetree additions, that need to wait for both
> bindings (and driver) changes to get applied to the media tree.
>
> Thanks
> Heiko
>
>
> > Thanks for your feedback,
> > Alex.
> >
> > Alex Bee (10):
> >    ARM: dts: rockchip: add power controller for RK322x
> >    ARM: dts: rockchip: add power controller for RK3036
> >    dt-bindings: mfd: syscon: add Rockchip RK3036/RK3228 qos compatibles
> >    media: hantro: add support for Rockchip RK3066
> >    media: hantro: add support for Rockchip RK3036
> >    ARM: dts: rockchip: add vpu nodes for RK3066 and RK3188
> >    ARM: dts: rockchip: add vpu node for RK322x
> >    media: dt-bindings: media: rockchip-vpu: add new compatibles
> >    ARM: dts: rockchip: add vdec node for RK322x
> >    media: dt-bindings: media: rockchip-vdec: add RK3228 compatible
> >
> >   .../bindings/media/rockchip,vdec.yaml         |  10 +-
> >   .../bindings/media/rockchip-vpu.yaml          |  33 +++-
> >   .../devicetree/bindings/mfd/syscon.yaml       |   2 +
> >   arch/arm/boot/dts/rk3036.dtsi                 |  51 ++++++
> >   arch/arm/boot/dts/rk3066a.dtsi                |   4 +
> >   arch/arm/boot/dts/rk3188.dtsi                 |   5 +
> >   arch/arm/boot/dts/rk322x.dtsi                 | 139 ++++++++++++++-
> >   arch/arm/boot/dts/rk3xxx.dtsi                 |  12 ++
> >   drivers/staging/media/hantro/hantro_drv.c     |   2 +
> >   drivers/staging/media/hantro/hantro_hw.h      |   2 +
> >   drivers/staging/media/hantro/rk3288_vpu_hw.c  | 165 ++++++++++++++++++
> >   11 files changed, 414 insertions(+), 11 deletions(-)
> >
> >
> > base-commit: 5d765451c2409e63563fa6a3e8005bd03ab9e82f
I'll address your comments in v2 - see individual patches for specific 
replies (if any).

Thanks,

Alex