Re: [PATCH 1/1] sched/topology: Fix a spelling mistake in error message

[Leizhen (ThunderTown)]

On 2021/5/26 14:52, Ingo Molnar wrote:
> 
> * Leizhen (ThunderTown) <thunder.leizhen@xxxxxxxxxx> wrote:
> 
>>
>>
>> On 2021/5/26 10:32, Randy Dunlap wrote:
>>> On 5/25/21 7:18 PM, Zhen Lei wrote:
>>>> The misspelled word 'borken' should be 'broken'.
>>>>
>>>> Fixes: 6ae72dff3759 ("sched: Robustify topology setup")
>>>> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>>>> ---
>>>>  kernel/sched/topology.c | 2 +-
>>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
>>>> index 55a0a243e871..80295e224442 100644
>>>> --- a/kernel/sched/topology.c
>>>> +++ b/kernel/sched/topology.c
>>>> @@ -1937,7 +1937,7 @@ static struct sched_domain *build_sched_domain(struct sched_domain_topology_leve
>>>>  
>>>>  		if (!cpumask_subset(sched_domain_span(child),
>>>>  				    sched_domain_span(sd))) {
>>>> -			pr_err("BUG: arch topology borken\n");
>>>> +			pr_err("BUG: arch topology broken\n");
>>>
>>> Would "borked" or "b0rken" be clearer?
>>
>> These two words don't seem to exist at all. Linux is an open-source
>> code for the world, so it's better to use a more common word.
> 
> What?
> 
> Please google:
> 
>     "borken" meaning

Hi, Ingo and Randy:
  I apologize to you both. In fact, I googled 'borken' before posting this patch.
But the result is: Borken is a German town. But I really didn't Google "borked"
and "b0rken", I just looked it up with an English dictionary software, but it
doesn't exist.
  As Randy's advice, it would be better to use "borked". At least it doesn't feel
like the 'r' and 'o' in "broken" are written in reverse order. There is no semantic
error in using "broken" in this sentence.

> 
> Please stop these pointless patches.

He who does not know is not guilty.

> 
> Thanks,
> 
> 	Ingo
> 
> .
>