Re: Suggestion on how to fix "memory leak in snd_ctl_led_register"

[慕冬亮]

On Thu, May 27, 2021 at 12:20 PM 慕冬亮 <mudongliangabcd@xxxxxxxxx> wrote:
>
> On Thu, May 27, 2021 at 12:17 PM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Thu, May 27, 2021 at 10:49:22AM +0800, 慕冬亮 wrote:
> > > Hi kernel developers,
> > >
> > > The root cause of "memory leak in snd_ctl_led_register" [1] is
> > > unbalanced refcount operations in the device_add function [2]. This
> > > refcount issue causes struct device_private allocated in
> > > device_private_init unable to be deallocated, leading to memory leak.
> > > The details are as follows:
> >
> > <snip>
> >
> > Great, can you just send a patch to us to resolve the issue?  That's the
> > easiest way to resolve all of this.

Let me think more about the fix. I will send a patch if I can test it
successfully in my local workspace.

>
> As I said in the last, I think up some fixes, but they are not working
> in my local testing. So I have no idea how to fix this bug. Then I ask
> for help.
>
> >
> > thanks,
> >
> > greg k-h