Re: [PATCH v5 05/14] media: mtk-vcodec: venc: support START and STOP commands
From: Alexandre Courbot
Date: Thu May 27 2021 - 06:10:41 EST
On Fri, May 21, 2021 at 10:37 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
>
> On Wed, May 19, 2021 at 10:31 PM Alexandre Courbot
> <acourbot@xxxxxxxxxxxx> wrote:
> > Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxxxx>
> > [hsinyi: fix double-free issue if flush buffer was not dequeued by the
> > time streamoff is called]
> > Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>
>
> Per guideline[1]:
> > Notably, the last Signed-off-by: must always be that of the developer submitting the patch.
>
> In the case, should you provide another signed-off at the last line?
>
> [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
IIUC the main author's signoff should come first, and you should not
sign patches twice. checkpatch.pl did not raise any objection, so I
suppose the current form is correct?