Re: [PATCH] module: fix compile error that sect_empty() is not defined in init_build_id()

[Jessica Yu]

+++ Yu Kuai [27/05/21 19:14 +0800]:
> If 'CONFIG_SYS' is not enabled while 'CONFIG_KALLSYMS' is enabled,
> fix following compile error:
>
> kernel/module.c:2805:8: error: implicit declaration of function ‘sect_empty’;
> did you mean ‘desc_empty’? [-Werror=implicit-function-declaration]
>
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Hi,

This has already been fixed in linux-next, see:

    https://lore.kernel.org/r/20210525105049.34804-1-cuibixuan@xxxxxxxxxx

> ---
> kernel/module.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index decf4601e943..173acb2aecc7 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2794,7 +2794,8 @@ static void add_kallsyms(struct module *mod, const struct load_info *info)
> }
> #endif /* CONFIG_KALLSYMS */
>
> -#if IS_ENABLED(CONFIG_KALLSYMS) && IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
> +#if IS_ENABLED(CONFIG_SYSFS) && IS_ENABLED(CONFIG_KALLSYMS) &&\
> +	IS_ENABLED(CONFIG_STACKTRACE_BUILD_ID)
> static void init_build_id(struct module *mod, const struct load_info *info)
> {
> 	const Elf_Shdr *sechdr;
> --
> 2.25.4