Re: [PATCH] regulator: fan53555: add back tcs4526

[Mark Brown]

On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
> On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:

> > +               reg = <0x1c>;
> > +               vin-supply = <&vcc5v0_sys>;
> > +               regulator-compatible = "fan53555-reg";

> I can be wrong, but I think regulator-compatible is deprecated.

Yes.

> > +               regulator-ramp-delay = <1000>;
> > +               fcs,suspend-voltage-selector = <1>;
> > +               regulator-always-on;
> > +               regulator-boot-on;

> Just out of curiosity, is regulator-boot-on really needed for the GPU?

It should only be used if it's not possible to read the state of
the regulator enable from the hardware.

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

Attachment: signature.asc
Description: PGP signature