Re: [RFC v2-fix-v2 1/1] x86/traps: Add #VE support for TDX guest
From: Sean Christopherson
Date: Thu May 27 2021 - 12:25:01 EST
On Thu, May 27, 2021, Luck, Tony wrote:
> +struct ve_info {
> + u64 exit_reason;
> + u64 exit_qual;
> + u64 gla;
> + u64 gpa;
> + u32 instr_len;
> + u32 instr_info;
> +};
>
> I guess that "gla" = Guest Linear Address ... which is a very "Intel" way of
> describing what everyone else would call a Guest Virtual Address.
>
> I don't feel strongly about this though. If this has already been hashed
> out already then stick with this name.
The "real" #VE information area that TDX is usurping is an architectural struct
that defines exit_reason, exit_qual, gla, and gpa, and those fields in turn come
directly from their corresponding VMCS fields with longer versions of the same
names, e.g. ve_info->gla is a reflection of vmcs.GUEST_LINEAR_ADDRESS.
So normally I would agree that the "linear" terminology is obnoxious, but in
this specific case I think it's warranted.