Re: [PATCH] HID: usbmouse: Avoid GFP_ATOMIC when GFP_KERNEL is possible

[Greg KH]

On Fri, May 28, 2021 at 01:45:17AM +0900, Hyeonggon Yoo wrote:
> On Mon, May 24, 2021 at 11:57:43PM +0900, Hyeonggon Yoo wrote:
> > probe in usb don't need to be atomic. So GFP_KERNEL can be used here,
> > instead of GFP_ATOMIC.
> > 
> > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@xxxxxxxxx>
> > ---
> >  drivers/hid/usbhid/usbmouse.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/hid/usbhid/usbmouse.c b/drivers/hid/usbhid/usbmouse.c
> > index 073127e65ac1..c89332017d5d 100644
> > --- a/drivers/hid/usbhid/usbmouse.c
> > +++ b/drivers/hid/usbhid/usbmouse.c
> > @@ -130,7 +130,7 @@ static int usb_mouse_probe(struct usb_interface *intf, const struct usb_device_i
> >  	if (!mouse || !input_dev)
> >  		goto fail1;
> >  
> > -	mouse->data = usb_alloc_coherent(dev, 8, GFP_ATOMIC, &mouse->data_dma);
> > +	mouse->data = usb_alloc_coherent(dev, 8, GFP_KERNEL, &mouse->data_dma);
> >  	if (!mouse->data)
> >  		goto fail1;
> >  
> > -- 
> > 2.25.1
> > 
> 
> Hello for me it was simple and obvious patch.
> Is there something wrong about it?

It has been only 4 days.  For a non-bugfix and for something that is
only a "cleanup" change, give it at least 2 weeks please.

Relax, there is no rush for stuff like this.

thanks,

greg k-h