Re: [PATCH] x86: fixmap: use CONFIG_NR_CPUS instead of NR_CPUS

[Mel Gorman]

On Thu, May 27, 2021 at 08:48:02AM -0700, Randy Dunlap wrote:
> > Dropping "mm/early_ioremap: add prototype for early_memremap_pgprot_adjust"
> > is one option. Alternatively, this should also work and it's a more
> > sensible dependency.
> > 
> > diff --git a/include/asm-generic/early_ioremap.h b/include/asm-generic/early_ioremap.h
> > index 022f8f908b42..d95c693de640 100644
> > --- a/include/asm-generic/early_ioremap.h
> > +++ b/include/asm-generic/early_ioremap.h
> > @@ -3,7 +3,7 @@
> >  #define _ASM_EARLY_IOREMAP_H_
> >  
> >  #include <linux/types.h>
> > -#include <asm/fixmap.h>
> > +#include <linux/pgtable.h>
> >  
> >  /*
> >   * early_ioremap() and early_iounmap() are for temporary early boot-time
> > 
> 
> That patch also lots of (different) problems:
> 

Ok, thanks. Turns out the header dependencies are many and it ends
either including a bunch of headers or else just mm_types.h. That's
a lot to import just to get a working definition of pgprot_t and some
other configuration could still be missed leaving linux-next broken for
same people.

Andrew, can you drop
mm-early_ioremap-add-prototype-for-early_memremap_pgprot_adjust-fix.patch
from mmotm please? It's caused more hassle than it's worth.

-- 
Mel Gorman
SUSE Labs