Re: [PATCH] selftests/seccomp: More closely track fds being assigned

[Kees Cook]

On Thu, May 27, 2021 at 02:45:26PM +0200, Rodrigo Campos wrote:
> On Thu, May 27, 2021 at 5:29 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
> >
> > Since the open fds might not always start at "4" (especially when
> > running under kselftest, etc), start counting from the first assigned
> > fd, rather than using the more permissive EXPECT_GE(fd, 0).
> >
> > Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>
> 
> Nice cleanup, thanks! Just in case, tested it here, works fine. Feel
> free to add:
> 
> Reviewed-by: Rodrigo Campos <rodrigo@xxxxxxxxxx>

Thanks!

> I can improve the selftest to test the new addfd flag we just added
> also in combination existing flags (like setting the fd number to
> use), and maybe also split the big chunk test, if you think that is
> valuable.

Yeah, I was pondering splitting the test up, but I think it's okay how
it is for now.

-- 
Kees Cook