arch/powerpc/platforms/83xx/suspend.c:210:3: error: implicit declaration of function 'enable_kernel_fp'

From: kernel test robot
Date: Thu May 27 2021 - 14:58:48 EST


Hi Christophe,

FYI, the error/warning still remains.

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: d7c5303fbc8ac874ae3e597a5a0d3707dc0230b4
commit: 7d68c89169508064c460a1208f38ed0589d226fa powerpc/32s: Allow deselecting CONFIG_PPC_FPU on mpc832x
date: 6 months ago
config: powerpc-randconfig-r015-20210526 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 6505c630407c5feec818f0bb1c284f9eeebf2071)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install powerpc cross compiling tool for clang build
# apt-get install binutils-powerpc-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7d68c89169508064c460a1208f38ed0589d226fa
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 7d68c89169508064c460a1208f38ed0589d226fa
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> arch/powerpc/platforms/83xx/suspend.c:210:3: error: implicit declaration of function 'enable_kernel_fp' [-Werror,-Wimplicit-function-declaration]
enable_kernel_fp();
^
1 error generated.

Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for HOTPLUG_CPU
Depends on SMP && (PPC_PSERIES || PPC_PMAC || PPC_POWERNV || FSL_SOC_BOOKE
Selected by
- PM_SLEEP_SMP && SMP && (ARCH_SUSPEND_POSSIBLE || ARCH_HIBERNATION_POSSIBLE && PM_SLEEP


vim +/enable_kernel_fp +210 arch/powerpc/platforms/83xx/suspend.c

87faaabb09d080 Anton Vorontsov 2009-12-10 173
d49747bdfb2dde Scott Wood 2007-10-09 174 static int mpc83xx_suspend_enter(suspend_state_t state)
d49747bdfb2dde Scott Wood 2007-10-09 175 {
d49747bdfb2dde Scott Wood 2007-10-09 176 int ret = -EAGAIN;
d49747bdfb2dde Scott Wood 2007-10-09 177
d49747bdfb2dde Scott Wood 2007-10-09 178 /* Don't go to sleep if there's a race where pci_pm_state changes
d49747bdfb2dde Scott Wood 2007-10-09 179 * between the agent thread checking it and the PM code disabling
d49747bdfb2dde Scott Wood 2007-10-09 180 * interrupts.
d49747bdfb2dde Scott Wood 2007-10-09 181 */
d49747bdfb2dde Scott Wood 2007-10-09 182 if (wake_from_pci) {
d49747bdfb2dde Scott Wood 2007-10-09 183 if (pci_pm_state != (deep_sleeping ? 3 : 2))
d49747bdfb2dde Scott Wood 2007-10-09 184 goto out;
d49747bdfb2dde Scott Wood 2007-10-09 185
d49747bdfb2dde Scott Wood 2007-10-09 186 out_be32(&pmc_regs->config1,
d49747bdfb2dde Scott Wood 2007-10-09 187 in_be32(&pmc_regs->config1) | PMCCR1_PME_EN);
d49747bdfb2dde Scott Wood 2007-10-09 188 }
d49747bdfb2dde Scott Wood 2007-10-09 189
d49747bdfb2dde Scott Wood 2007-10-09 190 /* Put the system into low-power mode and the RAM
d49747bdfb2dde Scott Wood 2007-10-09 191 * into self-refresh mode once the core goes to
d49747bdfb2dde Scott Wood 2007-10-09 192 * sleep.
d49747bdfb2dde Scott Wood 2007-10-09 193 */
d49747bdfb2dde Scott Wood 2007-10-09 194
d49747bdfb2dde Scott Wood 2007-10-09 195 out_be32(&pmc_regs->config, PMCCR_SLPEN | PMCCR_DLPEN);
d49747bdfb2dde Scott Wood 2007-10-09 196
d49747bdfb2dde Scott Wood 2007-10-09 197 /* If it has deep sleep (i.e. it's an 831x or compatible),
d49747bdfb2dde Scott Wood 2007-10-09 198 * disable power to the core upon entering sleep mode. This will
d49747bdfb2dde Scott Wood 2007-10-09 199 * require going through the boot firmware upon a wakeup event.
d49747bdfb2dde Scott Wood 2007-10-09 200 */
d49747bdfb2dde Scott Wood 2007-10-09 201
d49747bdfb2dde Scott Wood 2007-10-09 202 if (deep_sleeping) {
87faaabb09d080 Anton Vorontsov 2009-12-10 203 mpc83xx_suspend_save_regs();
87faaabb09d080 Anton Vorontsov 2009-12-10 204
d49747bdfb2dde Scott Wood 2007-10-09 205 out_be32(&pmc_regs->mask, PMCER_ALL);
d49747bdfb2dde Scott Wood 2007-10-09 206
d49747bdfb2dde Scott Wood 2007-10-09 207 out_be32(&pmc_regs->config1,
d49747bdfb2dde Scott Wood 2007-10-09 208 in_be32(&pmc_regs->config1) | PMCCR1_POWER_OFF);
d49747bdfb2dde Scott Wood 2007-10-09 209
d49747bdfb2dde Scott Wood 2007-10-09 @210 enable_kernel_fp();
d49747bdfb2dde Scott Wood 2007-10-09 211
d49747bdfb2dde Scott Wood 2007-10-09 212 mpc83xx_enter_deep_sleep(immrbase);
d49747bdfb2dde Scott Wood 2007-10-09 213
d49747bdfb2dde Scott Wood 2007-10-09 214 out_be32(&pmc_regs->config1,
d49747bdfb2dde Scott Wood 2007-10-09 215 in_be32(&pmc_regs->config1) & ~PMCCR1_POWER_OFF);
d49747bdfb2dde Scott Wood 2007-10-09 216
d49747bdfb2dde Scott Wood 2007-10-09 217 out_be32(&pmc_regs->mask, PMCER_PMCI);
87faaabb09d080 Anton Vorontsov 2009-12-10 218
87faaabb09d080 Anton Vorontsov 2009-12-10 219 mpc83xx_suspend_restore_regs();
d49747bdfb2dde Scott Wood 2007-10-09 220 } else {
d49747bdfb2dde Scott Wood 2007-10-09 221 out_be32(&pmc_regs->mask, PMCER_PMCI);
d49747bdfb2dde Scott Wood 2007-10-09 222
d49747bdfb2dde Scott Wood 2007-10-09 223 mpc6xx_enter_standby();
d49747bdfb2dde Scott Wood 2007-10-09 224 }
d49747bdfb2dde Scott Wood 2007-10-09 225
d49747bdfb2dde Scott Wood 2007-10-09 226 ret = 0;
d49747bdfb2dde Scott Wood 2007-10-09 227
d49747bdfb2dde Scott Wood 2007-10-09 228 out:
d49747bdfb2dde Scott Wood 2007-10-09 229 out_be32(&pmc_regs->config1,
d49747bdfb2dde Scott Wood 2007-10-09 230 in_be32(&pmc_regs->config1) & ~PMCCR1_PME_EN);
d49747bdfb2dde Scott Wood 2007-10-09 231
d49747bdfb2dde Scott Wood 2007-10-09 232 return ret;
d49747bdfb2dde Scott Wood 2007-10-09 233 }
d49747bdfb2dde Scott Wood 2007-10-09 234

:::::: The code at line 210 was first introduced by commit
:::::: d49747bdfb2ddebea24d1580da55b79d093d48a9 powerpc/mpc83xx: Power Management support

:::::: TO: Scott Wood <scottwood@xxxxxxxxxxxxx>
:::::: CC: Kumar Gala <galak@xxxxxxxxxxxxxxxxxxx>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip