Re: [RESEND PATCH V1 4/5] PCI: tegra: Don't allow suspend when Tegra PCIe is in EP mode

[Krzysztof Wilczyński]

Hi,

> > +	if (pcie->mode == DW_PCIE_EP_TYPE) {
> > +		dev_err(dev, "Tegra PCIe is in EP mode, suspend not allowed");
> > +		return -EPERM;
> > +	}
> 
> Would the -EINVAL be more appropriate here?  It seem more appropriate
> when something is an invalid operation, rather than access to the
> resource being denied (or something along these lines), what do you
> think?

After looking at this again, perhaps -ENOTSUPP would be a better fit,
and then the message could say that the suspend is not supported.

	Krzysztof