Re: [PATCH v2 1/7] crypto: fix a memory leak in sm2

From: Tianjia Zhang
Date: Fri May 28 2021 - 02:27:49 EST


Hi Herbert, Hongbo,

On 5/27/21 9:53 PM, Hongbo Li wrote:
From: Hongbo Li <herberthbli@xxxxxxxxxxx>

SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
test_akcipher_one(), it will set public key for every test vector,
and don't free ec->Q. This will cause a memory leak.

This patch alloc ec->Q in sm2_ec_ctx_init().

Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric cipher algorithm")
Signed-off-by: Hongbo Li <herberthbli@xxxxxxxxxxx>
Reviewed-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>
---
crypto/sm2.c | 24 ++++++++++--------------
1 file changed, 10 insertions(+), 14 deletions(-)


Patch 1/7 is an independent bugfix patch. If possible, consider applying it first.

The commit message header should start with: crypto: sm2 -

Also added:

Cc: stable@xxxxxxxxxxxxxxx # v5.10+

Best regards,
Tianjia