Re: [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id'
From: Uwe Kleine-König
Date: Fri May 28 2021 - 05:41:32 EST
Hello Lee,
On Fri, May 28, 2021 at 10:06:16AM +0100, Lee Jones wrote:
> diff --git a/drivers/leds/leds-gpio-register.c b/drivers/leds/leds-gpio-register.c
> index b9187e71e0cf2..de3f12c2b80d7 100644
> --- a/drivers/leds/leds-gpio-register.c
> +++ b/drivers/leds/leds-gpio-register.c
> @@ -11,6 +11,7 @@
> /**
> * gpio_led_register_device - register a gpio-led device
> * @pdata: the platform data used for the new device
> + * @id: platform ID
> *
Given that id is the first parameter and pdata the second I suggest to
swap the order here and describe id first.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature