Re: [PATCH] media: atomisp: remove compat_ioctl32 code

[Sakari Ailus]

On Fri, May 28, 2021 at 09:19:46AM +0200, Arnd Bergmann wrote:
> On Mon, May 24, 2021 at 5:18 PM Sakari Ailus
> <sakari.ailus@xxxxxxxxxxxxxxx> wrote:
> > On Sun, May 16, 2021 at 10:47:43PM +0200, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@xxxxxxxx>
> > >
> > > This is one of the last remaining users of compat_alloc_user_space()
> > > and copy_in_user(), which are in the process of getting removed.
> > >
> > > As of commit 57e6b6f2303e ("media: atomisp_fops.c: disable
> > > atomisp_compat_ioctl32"), nothing in this file is actually getting used
> > > as the only reference has been stubbed out.
> >
> > This patch was made redundant by another one that fixed the bug. But I
> > guess you're right in the sense that no-one could have used this because of
> > the patch that disabled it.
> >
> > So:
> >
> > Acked-by: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> >
> > But:
> >
> > > diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> > > index f1e6b2597853..e383e17c5072 100644
> > > --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
> > > +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
> > > @@ -1283,7 +1283,8 @@ const struct v4l2_file_operations atomisp_fops = {
> > >       .unlocked_ioctl = video_ioctl2,
> > >  #ifdef CONFIG_COMPAT
> > >       /*
> > > -      * There are problems with this code. Disable this for now.
> > > +      * this was removed because of bugs, the interface
> > > +      * needs to be made safe for compat tasks instead.
> > >       .compat_ioctl32 = atomisp_compat_ioctl32,
> >
> > I think the comment could go, too.
> 
> Should I replace it with an entry in the TODO file then?

On second thought, it's fine.

The lack of compat ioctl support is not among the biggest issues anyway.

-- 
Sakari Ailus